Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update link to docker build reference #2186

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Jan 11, 2024

Update link to the docker build CLI reference

@dvdksn
Copy link
Contributor Author

dvdksn commented Jan 16, 2024

I marked as do not merge but actually it should be fine to merge. It depends on the moby 25 release, but that's not a blocker for merging

edit: hmm on the other hand, merging would cause the docs validation CI failure to appear everywhere so maybe let's hold until moby 25

@@ -501,7 +501,7 @@ func buildCmd(dockerCli command.Cli, rootOpts *rootOptions, debugConfig *debug.D
flags := cmd.Flags()

flags.StringSliceVar(&options.extraHosts, "add-host", []string{}, `Add a custom host-to-IP mapping (format: "host:ip")`)
flags.SetAnnotation("add-host", annotation.ExternalURL, []string{"https://docs.docker.com/engine/reference/commandline/build/#add-host"})
flags.SetAnnotation("add-host", annotation.ExternalURL, []string{"https://docs.docker.com/engine/reference/commandline/image_build/#add-host"})
Copy link
Member

@crazy-max crazy-max Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I thought it would be image/build, not image_build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be. I am not moving all the pages yet. First step is to get rid of the duplicates (aliases) and only keep the canonical files.

@dvdksn dvdksn force-pushed the docs-fix-cli-reference-link branch from 780b3e4 to 68c3ac4 Compare January 19, 2024 14:28
@dvdksn
Copy link
Contributor Author

dvdksn commented Jan 19, 2024

@crazy-max rebased, this should be good to go

@crazy-max
Copy link
Member

@dvdksn Looks like there is an issue with docs workflow: https://github.com/docker/buildx/actions/runs/7585104346/job/20660277217?pr=2186#step:6:489

#27 [validate-upstream 5/5] RUN htmltest
#27 0.053 htmltest started at 02:32:51 on public
#27 0.053 ========================================================================
#27 4.262 engine/reference/commandline/buildx_build/index.html
#27 4.262   hash does not exist --- engine/reference/commandline/buildx_build/index.html --> /engine/reference/commandline/image_build/#build-arg
#27 4.262 ========================================================================
#27 10.11 ✘✘✘ failed in 10.052181108s
#27 10.11 1 errors in 2120 documents
#27 10.11 
#27 ERROR: process "/bin/sh -c htmltest" did not complete successfully: exit code: 1

I guess it needs changes first from docs repo?

@dvdksn
Copy link
Contributor Author

dvdksn commented Jan 19, 2024

Yes this is expected, chicken and egg problem. I am renaming the page, but this file contains a link to the old page url...

@crazy-max crazy-max merged commit d852568 into docker:master Jan 19, 2024
62 of 63 checks passed
@dvdksn dvdksn deleted the docs-fix-cli-reference-link branch January 19, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants