Skip to content

Commit

Permalink
packages update & node v20
Browse files Browse the repository at this point in the history
  • Loading branch information
karczk-dnv committed Dec 6, 2023
1 parent 5b54b1a commit f64f076
Show file tree
Hide file tree
Showing 5 changed files with 986 additions and 1,034 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:

strategy:
matrix:
node-version: [18.x]
node-version: [20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_to_npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
# Setup .npmrc file to publish to npm
- uses: actions/setup-node@v2
with:
node-version: '18.x'
node-version: '20.x'
registry-url: 'https://registry.npmjs.org'
scope: '@dnvgl'
- run: yarn
Expand Down
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ Check tools and rules described below.

### Node.js - build runtime environment
- how to: visit site https://nodejs.org/en and install (msi installer, default options)
- version: newest `18.xx`
- verification: run `node -v` in cmd, expected example: `v18.12.0`
- version: newest `20.xx`
- verification: run `node -v` in cmd, expected example: `v20.10.0`

### npm - package manager
- how to: `npm install -g npm@latest`
- version: minimum `7.x`
- verification: run `npm -v` in cmd, expected example: `v8.3.1`
- version: minimum `8.x`
- verification: run `npm -v` in cmd, expected example: `v8.19.3`

### Yarn classic - package manager
- how to: `npm install -g yarn` (that's it!)
Expand All @@ -29,7 +29,7 @@ Check tools and rules described below.

### Visual Studio Code + TypeScript
- Press `ctrl+shift+p` in a TypeScript file -> choose "Select TypeScript Version" -> pick "Use Workspace Version"
- verification: open TypeScript file (*.ts or *.tsx), expected example on the bottom right: `Typescript 4.8.4`
- verification: open TypeScript file (*.ts or *.tsx), expected example on the bottom right: `Typescript 5.3.2`

## 3. Project configuration/installation

Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@
},
"license": "MIT",
"devDependencies": {
"@types/jest": "^29.5.0",
"@types/node": "^18.15.11",
"@types/jest": "^29.5.11",
"@types/node": "^20.10.3",
"jest": "^29.5.0",
"jest-environment-jsdom": "^29.5.0",
"rimraf": "^5.0.0",
"ts-jest": "^29.1.0",
"rimraf": "^5.0.1",
"ts-jest": "^29.1.1",
"ts-node": "^10.8.0",
"typescript": "^5.0.4"
"typescript": "^5.3.2"
}
}
Loading

0 comments on commit f64f076

Please sign in to comment.