Add OIDC with Passage2 #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On va avoir besoin d'une description du parcours utilisateurs associé à ce que tu as implémenté. |
leihuayi
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Rather than using .env file (which we will need to put in environment), couldn't we set the variables in the frontend dockerfile at build ?
....
FROM base as dev
ENV VUE_APP_OIDC_AUTHORITY=XXX
ENV VUE_APP_OIDC_CLIENT_ID=YYY
CMD ["npm", "run", "dev"]
FROM base as build
ENV VUE_APP_OIDC_AUTHORITY=XXX
ENV VUE_APP_OIDC_CLIENT_ID=YYY
RUN npm run build
thomashbrnrd
force-pushed
the
passage2
branch
2 times, most recently
from
a1db6e9
to
27b6794
Compare
thomashbrnrd
force-pushed
the
passage2
branch
2 times, most recently
from
8297cf6
to
49de2ed
Compare
2 tasks
|
Grâce à cette PR côté frontend tout est présent, il faudra vérifier si il ne faut pas changer les scops en fonction de Passage2 car tout est testé localement avec un keycloak générique, dont la config est la suivante : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.