Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/use s3 instead of swift #177

Merged
merged 10 commits into from
Oct 3, 2023
Merged

Conversation

thomashbrnrd
Copy link
Collaborator

No description provided.

@thomashbrnrd thomashbrnrd changed the base branch from main to develop September 8, 2023 12:57
@github-actions github-actions bot added the enhancement Improvement of existing code w/o creating new feature label Sep 8, 2023
@leihuayi leihuayi force-pushed the enh/use-s3-instead-of-swift branch 3 times, most recently from f61e17d to 2665008 Compare September 21, 2023 14:34
@leihuayi
Copy link
Collaborator

@thomashbrnrd think of putting a comment on your PR next time please ;)

  • remove all previous var for swift OS_... and replace by AWS_... in ci/cds
  • use by default remote variables, in dev mode use minio
  • update unit tests (remove testing the download of uploaded image since the url of remote image currently does not work - see TODO)

TODO:

  • the image_url written in logs actually does not work: although the image is correctly uploaded in s3, the direct url link shows an error in browser :/ I asked the OVH team and according to them the url used in this PR is correct so I don't know what the problem is.
  • I haven't managed to simulate the dev usage with minio locally, I don't know how it is supposed to work. It seems to fail since I don't have the log "Upload successful" when I try with minio instead of remote OVH s3.
  • Add some verifications of whether the connection is successful. Write an error log if the credentials are incorrect to help for debugging (can use env variable WORKSPACE if necessary) but prevent failure of the application if that is the case = we want the app to run even if the photo upload fails.

@thomashbrnrd thomashbrnrd merged commit cf09614 into develop Oct 3, 2023
3 checks passed
@thomashbrnrd thomashbrnrd deleted the enh/use-s3-instead-of-swift branch October 3, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing code w/o creating new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants