test: ✅ add e2e and api tests

dnum-mi · Aug 30, 2024 · d29b3ae · d29b3ae
1 parent 136dab6
commit d29b3ae
Show file tree

Hide file tree

Showing 10 changed files with 48 additions and 11 deletions.
diff --git a/backend/tests/blank_gun.jpg b/backend/tests/blank_gun.jpg
diff --git a/backend/tests/low_quality.jpg b/backend/tests/low_quality.jpg
diff --git a/backend/tests/no_text.jpg b/backend/tests/no_text.jpg
diff --git a/backend/tests/test_api.py b/backend/tests/test_api.py
@@ -186,3 +186,41 @@ def test_403(self):
         response = client.post("/api/expert-contact")
         response.data = response.json()
         assert response.status_code == 403
+
+
+class TestBlankGunUpload:
+    def test_blank_gun(self):
+        with open("./tests/blank_gun.jpg", "rb") as f:
+            response = client.post(
+                "/api/identification-blank-gun",
+                files={"image": f},
+            )
+        response.data = response.json()
+        assert response.status_code == 200
+        assert response.data["alarm_model"] == "Alarm_model"
+        assert response.data["missing_text"] == False
+        assert response.data["low_quality"] == False
+
+    def test_bad_quality(self):
+        with open("./tests/low_quality.jpg", "rb") as f:
+            response = client.post(
+                "/api/identification-blank-gun",
+                files={"image": f},
+            )
+        response.data = response.json()
+        assert response.status_code == 200
+        assert response.data["alarm_model"] == None
+        assert response.data["missing_text"] == False
+        assert response.data["low_quality"] == True
+
+    def test_missing_text(self):
+        with open("./tests/no_text.jpg", "rb") as f:
+            response = client.post(
+                "/api/identification-blank-gun",
+                files={"image": f},
+            )
+        response.data = response.json()
+        assert response.status_code == 200
+        assert response.data["alarm_model"] == None
+        assert response.data["missing_text"] == True
+        assert response.data["low_quality"] == False
diff --git a/frontend/cypress/e2e/firearm-confidence.cy.js b/frontend/cypress/e2e/firearm-confidence.cy.js
@@ -12,6 +12,7 @@ describe("Firearm Confidence", () => {
     });
     cy.getByDataTestid("next-step").click();
     cy.IdentificationPistoletSemiAuto();
+    cy.wait(5000);
     cy.url().should("contain", "/guide-identification/resultat-final");
     cy.getByDataTestid("arm-category").should("contain", "Catégorie B");
   });

diff --git a/frontend/cypress/e2e/firearm-identification.cy.js b/frontend/cypress/e2e/firearm-identification.cy.js
@@ -11,6 +11,7 @@ describe("Firearm Identification", () => {
     });
     cy.getByDataTestid("next-step").click();
     cy.IdentificationPistoletSemiAuto();
+    cy.wait(5000);
     cy.url().should("contain", "/guide-identification/resultat-final");
     cy.getByDataTestid("arm-category").should("contain", "Catégorie B");
     cy.getByDataTestid("return-to-home-end").click();

diff --git a/frontend/cypress/e2e/firearm-securing.cy.js b/frontend/cypress/e2e/firearm-securing.cy.js
@@ -26,6 +26,7 @@ describe("Securing Firearm and Identification", () => {
     cy.contains("p", "Basegun a identifié votre arme");
     cy.getByDataTestid("next-step").click();
     cy.IdentificationPistoletSemiAuto();
+    cy.wait(5000);
     cy.url().should("contain", "/guide-identification/resultat-final");
     cy.getByDataTestid("arm-category").should("contain", "Catégorie B");
     cy.getByDataTestid("return-to-home-end").click();

diff --git a/frontend/cypress/support/commands.js b/frontend/cypress/support/commands.js
@@ -109,11 +109,8 @@ Cypress.Commands.add("IdentificationPistoletSemiAuto", () => {
   cy.contains("Cartouches").first().click();
   cy.getByDataTestid("next-step").should("not.have.attr", "disabled");
   cy.getByDataTestid("next-step").click();
-  cy.url().should("contain", "/guide-identification/armes-alarme");
-  cy.getByDataTestid("instruction-armeAlarme").should("contain", "Votre arme");
-  cy.getByDataTestid("next-step").click();
-  cy.getByDataTestid("aucune-correspondance").click();
-  cy.getByDataTestid("next-step").click();
+  cy.url().should("contain", "/guide-identification/qualite-image");
+  cy.getByDataTestid("title-page").should("contain", "Identification d'une arme d'alarme");
 });
 
 Cypress.Commands.add("IdentificationRevolver", () => {
@@ -133,11 +130,9 @@ Cypress.Commands.add("IdentificationRevolver", () => {
   cy.contains("Balles").first().click();
   cy.getByDataTestid("next-step").should("not.have.attr", "disabled");
   cy.getByDataTestid("next-step").click();
-  cy.url().should("contain", "/guide-identification/armes-alarme");
-  cy.getByDataTestid("instruction-armeAlarme").should("contain", "Votre arme");
-  cy.getByDataTestid("next-step").click();
-  cy.getByDataTestid("aucune-correspondance").click();
-  cy.getByDataTestid("next-step").click();
+  cy.url().should("contain", "/guide-identification/qualite-image");
+  cy.getByDataTestid("title-page").should("contain", "Marquages non détéctés");
+  cy.getByDataTestid("button-resultPage").click();
 });
 
 Cypress.Commands.add("arrierePlatRevolver", () => {

diff --git a/frontend/src/views/GuideIdentificationFirearm/GuideIdentificationFirearm.vue b/frontend/src/views/GuideIdentificationFirearm/GuideIdentificationFirearm.vue
@@ -296,6 +296,7 @@ watch(alarmModel, (newVal) => {
           :icon-right="true"
           icon="ri-checkbox-circle-line"
           secondary
+          data-testid="button-resultPage"
           @click="
             currentStep++;
             goToNewRouteWithArmeAlarme();

diff --git a/frontend/src/views/GuideIdentificationFirearm/IdentificationQualityImage.vue b/frontend/src/views/GuideIdentificationFirearm/IdentificationQualityImage.vue
@@ -111,7 +111,7 @@ const alert = computed(() => {
 </script>
 <template>
   <h2 class="fr-mt-3w flex justify-center titlePage">
-    <span> {{ title }}</span>
+    <span data-testid="title-page"> {{ title }}</span>
   </h2>
 
   <div class="fr-p-1w">