Skip to content

Commit

Permalink
ci(images-tags): use commit sha instead of branch name (#201)
Browse files Browse the repository at this point in the history
  • Loading branch information
thomashbrnrd committed Oct 24, 2023
1 parent 180847c commit 5a738b9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
with:
context: ./backend
push: true
tags: ghcr.io/datalab-mi/basegun/basegun-backend:${{ github.head_ref }}
tags: ghcr.io/datalab-mi/basegun/basegun-backend:${{ github.sha }}
target: dev

build-frontend:
Expand All @@ -54,15 +54,15 @@ jobs:
with:
context: ./frontend
push: true
tags: ghcr.io/datalab-mi/basegun/basegun-frontend:${{ github.head_ref }}
tags: ghcr.io/datalab-mi/basegun/basegun-frontend:${{ github.sha }}
target: prod

test-backend:
name: Test Backend
needs: build-backend
runs-on: ubuntu-latest
container:
image: ghcr.io/datalab-mi/basegun/basegun-backend:${{ github.head_ref }}
image: ghcr.io/datalab-mi/basegun/basegun-backend:${{ github.sha }}
env:
WORKSPACE: dev
AWS_REGION: gra
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-on-kube.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ jobs:
--set ingress.hosts[0].paths[0].path="/" \
--set ingress.hosts[0].paths[0].pathType="Prefix" \
--set backend.image.repository="ghcr.io/datalab-mi/basegun/basegun-backend" \
--set backend.image.tag="${{ github.head_ref }}" \
--set backend.image.tag="${{ github.sha }}" \
--set frontend.image.repository="ghcr.io/datalab-mi/basegun/basegun-frontend" \
--set frontend.image.tag="${{ github.head_ref }}" \
--set frontend.image.tag="${{ github.sha }}" \
--set backend.secret.create="true" \
--set-string backend.secret.values.AWS_ACCESS_KEY_ID="${{ secrets.AWS_ACCESS_KEY_ID }}" \
--set-string backend.secret.values.AWS_SECRET_ACCESS_KEY="${{ secrets.AWS_SECRET_ACCESS_KEY }}" \
Expand Down

0 comments on commit 5a738b9

Please sign in to comment.