Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for New-PasswordStateList -LinkToTemplate #162

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

miked1313
Copy link
Contributor

Great work on this PowerShell module! I was trying to create thousands of password lists from templates in bulk and ran into some issues with the module function and also directly with the PasswordState API.

  • Fixed New-PasswordStateList -LinkToTemplate so that it no longer requires a value for -Permission.
  • Added new TemplatePermission parameter set so that it is separate from Template and TemplateSettings.
  • Updated New-PasswordStateList doc page to reflect these changes
  • Changed New-PasswordStateList doc page: -LinkToTemplate needs to be "true" per ClickStudios Support - the API docs were incorrect and will be fixed in the next build. Using Boolean -LinkToTemplate $true appears to also work, awaiting confirmation from ClickStudios Support.
  • Added Example 4 to New-PasswordStateList doc page to show copying settings and permissions from a template and linking to the template

Fixed -CopyPermissionsFromTemplateID so it no longer requires a value for  -Permission
Updated to reflect fix to Template parameter set in the function
@miked1313
Copy link
Contributor Author

This code needs to be tested and may need to be fixed. I originally tried to fix the existing Parameter set Template locally and then changed to the new TemplatePermission parameter set. It wasn't clear in the code to me when Permission, Template, TemplateSettings are used, will have to re-read the doc file.

@dnewsholme dnewsholme merged commit 235d1f5 into dnewsholme:master Jan 19, 2024
3 checks passed
@dnewsholme
Copy link
Owner

Thanks for the submission. Changes look fine to me. Sorry about the delay at looking at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants