DEVEX-2418 #1409
DEVEX-2418 #1409
Conversation
Fix run of globalworkflow when the underlying workflow will be searched in dx env Current workspace instead of its onw container in the given region.
| dxid=underlying_workflow['workflow'], | ||
| project=underlying_workflow['resources'], | ||
| ) | ||
| self._workflows_by_region[region] = dxworkflow |
There was a problem hiding this comment.
We previously set self._workflow_desc_by_region variable to the DXWorkflow
With this change we set self._workflows_by_region[region]
Why are we no longer setting self._workflow_desc_by_region? It is used in describe_underlying_workflow.
There was a problem hiding this comment.
There was a confusion between 2 attributes, see def __init__()
# caches for underlying workflow instances and descriptions per region
# (they are immutable for a given global workflow)
self._workflows_by_region = {}
self._workflow_desc_by_region = {}
This method should only cache the workflow instances, not descriptions
There was a problem hiding this comment.
Have you tested that the caching in both cases still work as expected? If so, then LGTM
There was a problem hiding this comment.
If you are concerned about the behavior - you can wrap those in try ... except. Otherwise - could you identify the regression test that monitors this or maybe create one?
Fix run of globalworkflow when the underlying workflow will be searched in dx env Current workspace instead of its onw container in the given region.