Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Dotnet runtimes to the list of assemblies #290

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

QianMoXi
Copy link

Problem

In the assembly list, it has only contained content related to the .NET Framework for a long time. As .NET Core becomes increasingly popular, it's time to add the installed runtimes to the list.

Solution

This is a relatively simple solution—scan the files and add them to the list.

image

dnSpy/dnSpy/Documents/Tabs/DefaultDocumentList.cs Outdated Show resolved Hide resolved
dnSpy/dnSpy/Documents/Tabs/DefaultDocumentList.cs Outdated Show resolved Hide resolved
dnSpy/dnSpy/Documents/Tabs/DefaultDocumentList.cs Outdated Show resolved Hide resolved
@ElektroKill ElektroKill added the enhancement New feature or request label Feb 11, 2024
@QianMoXi
Copy link
Author

DotNetPathProvider is used and simultaneously displayed both x32 and x64 versions.
image

Copy link
Member

@ElektroKill ElektroKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a few code-style nitpicks, LGTM!

Please apply my suggestions regarding code style to all places where the issue can be observed, I only added a single comment for 1 issue to avoid polluting the review!

dnSpy/dnSpy.Contracts.Logic/Utilities/FrameworkPath.cs Outdated Show resolved Hide resolved
dnSpy/dnSpy.Contracts.Logic/Utilities/FrameworkPath.cs Outdated Show resolved Hide resolved
dnSpy/dnSpy.Contracts.Logic/Utilities/FrameworkPath.cs Outdated Show resolved Hide resolved
dnSpy/dnSpy/Documents/Tabs/DefaultDocumentList.cs Outdated Show resolved Hide resolved
dnSpy/dnSpy/Documents/Tabs/DefaultDocumentList.cs Outdated Show resolved Hide resolved
dnSpy/dnSpy/Documents/Tabs/DefaultDocumentList.cs Outdated Show resolved Hide resolved
@QianMoXi
Copy link
Author

It seems that Visual Studio is not adhering to the .editorconfig file, possibly due to my settings. I have done my best to make adjustments, but if there are still inconsistencies, please remind me.

@ElektroKill ElektroKill merged commit cc7533e into dnSpyEx:master Mar 1, 2024
3 checks passed
@ElektroKill
Copy link
Member

Merged, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants