Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rucio client version #12201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vkuznet
Copy link
Contributor

@vkuznet vkuznet commented Dec 10, 2024

Fixes #12032

Status

not-tested

Description

New version for rucio-clients

Is it backward compatible (if not, which system it affects?)

MAYBE

Related PRs

External dependencies / deployment changes

@vkuznet vkuznet self-assigned this Dec 10, 2024
@vkuznet vkuznet requested a review from amaltaro December 10, 2024 14:51
@vkuznet
Copy link
Contributor Author

vkuznet commented Dec 10, 2024

Alan, to proceed with testing we need to build new image which requires new tag. Therefore I made this PR to update version and asking for review. My understanding that we can merge this PR and then it will trigger new build images which can be used for deployment and testing.

Please advise how to proceed with that if procedure is different.

@dmwm-bot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/186/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

@vkuznet I am pretty sure that, if we follow this path, it will require multiple follow up pull requests.

My suggestion is, first take this the requirements.txt file and install it in an empty virtual environment and/or in our dmwm-base docker image (well, a custom one):
https://github.com/dmwm/CMSKubernetes/blob/master/docker/pypi/dmwm-base/Dockerfile#L3

I think we will have to adapt other packages as well (add, remove, update version, etc). Once you have an apparently functional requirements.txt file, we can then go the full cycle (pypi packaging + docker build + execution of the application).

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this comment through a review, just so this PR does not show up whenever I look for PRs awaiting for human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rucio-clients package to the latest stable release (34.4 ?)
3 participants