Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timing profile for each unit test #651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vkuznet
Copy link
Contributor

@vkuznet vkuznet commented May 2, 2021

No description provided.

@yuyiguo
Copy link
Member

yuyiguo commented May 3, 2021

@vkuznet

I don't think individual test timing has any meaning in DBS unit tests. This individual test mainly for cover different use cases. Each API speed is more depending on the DB load and the server load at the time it is executed. However, the overall speed does reflect some underline problems.

Adding individual timing may mislead the testers. So I will not commit the PR.

@vkuznet
Copy link
Contributor Author

vkuznet commented May 3, 2021

Yuyi, it is up to you, I only put PR to make it clear how I get those timing numbers. It also helped me to understand the difference in APIs. Will you use it or not it is totally your decision, but I felt it would be better documented (even as closed issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants