WIP If the model contains errors, display inline errors in jsoneditor #60
Conversation
…he JSON editor to 'always' in order to exhibit inline errors upon initialization.
germanbisurgi
changed the title
|
@germanbisurgi Does this also prevent the form from being sent to the server in the first place? |
…eClientValidation' => true. It' s job is to collect and display inline validation errors within the json-editor form. It also remove the added ".has-error" classes that Yii-2 adds everywhere in the json-editor indiscriminately.
…undant error messages
|
|
||
| public function clientValidateAttribute($model, $attribute, $view) | ||
| { | ||
| return <<<JS |
There was a problem hiding this comment.
Does it work, when using multiple JSONEditor on the same Page?
There was a problem hiding this comment.
The ClientSideJsonValidator works with the first json-editor it finds. Currently, Widgets2 uses only one json-editor at a time.
The publication module relies on Widgets2 as a dependency, I manually tested it and found no errors. It's worth noting that the publication module doesn't actively use the ClientSideJsonValidator. Instead, relies on the the regular json-editor error messages during interaction.
If you have any potential scenarios that could conflict with this pull request, please let me know. I know this PR could create more issues than it solves :)
There was a problem hiding this comment.
I added an extra check for the editor. In any case, if for some reason an error occurs during this client validation step, The page will just submit the form normally (no AJAX) and proceed with the normal flow, meaning backend validation and showing an error summary
There was a problem hiding this comment.
Is ClientSideJsonValidator specific to widgets2 or would it actually belong to https://github.com/dmstr/yii2-json-editor ?
There was a problem hiding this comment.
Is specific to widgets2
No description provided.