Skip to content
This repository was archived by the owner on May 9, 2018. It is now read-only.

Conversation

@Kanabanarama
Copy link

  • Move 'tooltip' under options since it isn't a standard JSON Schema keyword
{
  "type": "string",
  "minLength": 4,
  "options": {
    "tooltip": "This is a tooltip"
  }
}
  • Instead of adding another argument to getFormControl, I would create a new theme function addTooltip that takes a DOM node as an argument. That way it can be reused elsewhere and it will be easier for themes to override.
this.control = this.theme.getFormControl(this.label, this.input, this.description);
this.theme.addTooltip(this.control, this.tooltip);

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants