Update exchange API to be capsule following new convention #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @Kathryn-cat |
Member
Author
|
RFC thread #179 |
junrushao
approved these changes
Dec 5, 2025
Kathryn-cat
approved these changes
Dec 5, 2025
This PR updates the exchange API to be capsule following the new convention. Note that the exchange API python recommendation is not yet updated on the array-api side and so far there hasn't yet been downstream implementation, so this change should be safe in generally.
Member
Author
Member
Author
|
Array api spec PR data-apis/array-api#984 |
Collaborator
|
Sorry for delay, will try to finish my review in a day or two! |
leofang
requested changes
Dec 23, 2025
|
|
||
| .. code-block:: C | ||
| PyObject *api_obj = type(tensor_obj).__dlpack_c_exchange_api__; // as C code. |
Collaborator
There was a problem hiding this comment.
I am confused. Is this valid C code? Shouldn't we use PyObject_HasAttrString or alike to query if the Python attribute exists with this type?
Member
Author
There was a problem hiding this comment.
This is not valid C code, but as a pesudo cython like code to query the types, happy to change to C code here
| A reference implementations of the C Exchange API in frameworks: | ||
|
|
||
|
|
||
| * PyTorch: `C++ <https://github.com/pytorch/pytorch/blob/main/torch/csrc/Module.cpp#L692>`__ |
Collaborator
There was a problem hiding this comment.
Let's link to a particular commit (copy permalink) in case the upstream drifts away.
|
|
||
|
|
||
| * PyTorch: `C++ <https://github.com/pytorch/pytorch/blob/main/torch/csrc/Module.cpp#L692>`__ | ||
| * Paddle: `C++ <https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/fluid/pybind/pybind.cc#L856>`__ |
| direct interaction between the array framework PyObject* and DLPack, | ||
| as a result it is harder to implement the C Exchange API through ctypes (because | ||
| ctypes releases GIL by default and sometimes in non-free-threading environment, | ||
| GIL is needed to interact with the Python C API). |
Collaborator
| * | ||
| * PyObject *api_obj = type(tensor_obj).__c_dlpack_exchange_api__; // as C-code | ||
| * MyDLPackExchangeAPI *api = PyLong_AsVoidPtr(api_obj); | ||
| * PyObject *api_obj = type(tensor_obj).__dlpack_c_exchange_api__; // as C-code |
Collaborator
There was a problem hiding this comment.
Ditto, now that I take a closer look, this seems odd to me
Co-authored-by: Leo Fang <[email protected]>
Co-authored-by: Leo Fang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the exchange API to be capsule following the new convention. Note that the exchange API python recommendation is not yet updated on the array-api side and so far there hasn't yet been downstream implementation, so this change should be safe in generally.