Skip to content

Fix: Prevent crash from uninitialized last_id in convert_partition.py #7903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Prevent crash from uninitialized last_id in convert_partition.py #7903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions tools/distpartitioning/convert_partition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,8 +541,9 @@ def create_graph_object(
assert np.all(shuffle_global_nids[1:] - shuffle_global_nids[:-1] == 1)
shuffle_global_nid_range = (shuffle_global_nids[0], shuffle_global_nids[-1])

# Determine the node ID ranges of different node types.
# Determine the node ID ranges of different node types.
prev_last_id = last_ids.get(part_id - 1, 0)
max_last_id = prev_last_id # Initialize max_last_id before the loop
for ntype_name in global_nid_ranges:
ntype_id = ntypes_map[ntype_name]
type_nids = shuffle_global_nids[ntype_ids == ntype_id]
Expand All @@ -552,15 +553,17 @@ def create_graph_object(
node_map_val[ntype_name].append(
[int(type_nids[0]), int(type_nids[-1]) + 1]
)
last_id = th.tensor(
[max(prev_last_id, int(type_nids[-1]) + 1)], dtype=th.int64
)
# Update max_last_id with the maximum ID seen in this partition
max_last_id = max(max_last_id, int(type_nids[-1]) + 1)

# Create the last_id tensor after the loop to ensure it's always initialized
last_id = th.tensor([max_last_id], dtype=th.int64)
id_ntypes = list(global_nid_ranges.keys())

gather_last_ids = [
th.zeros(1, dtype=th.int64) for _ in range(dist.get_world_size())
]

dist.all_gather(gather_last_ids, last_id)
prev_last_id = _update_node_map(
node_map_val, gather_last_ids, id_ntypes, prev_last_id
Expand Down