Merge pull request #23 from dmitrizzle/remove-eval

replaced eval() with window[]
dmitrizzle · Apr 17, 2017 · 1d959c7 · 1d959c7
2 parents a5d32a3 + 0312a6d
commit 1d959c7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/component/Bubbles.js b/component/Bubbles.js
@@ -51,7 +51,7 @@ function Bubbles(container, self, options) {
 
   // navigate "answers"
   this.answer = function(key){
-  	var func = function(key){ typeof window[key] === "function" ? eval(key)() : false; }
+  	var func = function(key){ typeof window[key] === "function" ? window[key]() : false; }
   	this.convo[key] !== undefined ? this.reply(this.convo[key]) : func(key);
   };
 

diff --git a/component/start-here/hello.html b/component/start-here/hello.html
@@ -41,7 +41,7 @@
 				"reply": [
 					{
 						"question": "👍",
-						"answer" : "start"
+						"answer" : "functionTwo"
 					},
 					{
 						"question": "What for? 🤔",