refactor common sources to work with dlt+ #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djudjuu
force-pushed
the
feat/623/refactor-sources-to-work-with-dlt-project
branch
from
8bfdf17 to
e50a666
Compare
djudjuu
commented
May 22, 2025
| @@ -28,7 +29,7 @@ | |||
|
|
|||
|
|
|||
| @dlt.source | |||
| def asana_source() -> Any: # should be Sequence[DltResource]: | |||
| def asana_source(access_token: str = dlt.secrets.value) -> Sequence[DltResource]: | |||
| """ | |||
There was a problem hiding this comment.
I can just add the access token here, even though its not used, so that it shows up in the config
or remove it from the resources too and pass it down? but that seems less elegant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues