Repository navigation
Fix expandTilde: use getpwnam_r return value instead of errno - #11150
Merged
Merged
Conversation
POSIX reports the error through the return value. On macOS 15 errno is not ERANGE when the buffer is too small, which was reported as an OutOfMemoryError. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Diff LGTM but I don't understand this in the commit message:
Is |
thewilsonator
approved these changes
Nov 11, 2026
0xEAB
added
Severity:Bug Fix
Review:AI Generated
Member
|
@dkorpel |
Contributor
Author
|
Done |
Contributor
Author
According to POSIX, |
Member
|
Yeah, that part is clear. I was just confused by that sentence in that commit message, i.e. why it said "POSIX reports". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11151
Blocks dlang/dmd#24274
POSIX reports the error through the return value, superseding the unreliable errno checking (falling through to onOutOfMemoryError() on macOS 15).
This PR was written entirely by an LLM/AI.