-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#241 Update dependency Spring to version 6.x #242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spring 6 requires a Java 17 baseline, so we need to remove Java 11 from the GitHub runners and upgrade compile level to 17.
4b654be
to
4cec791
Compare
@rzo1 According to https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html we can set I, therefore, don't quite understand why the JRE 11 runner did complain. Further investigation required, I guess? EDIT: |
Yes - and that is the reason, why we can't stay with Java 11, if we want to use Spring 6 :-) |
DKPro Core Parent POM 30 sets the relevant target/source/release Maven properties to 11. |
For interested readers: https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-Versions |
If you want to override them, use:
|
Would move JWPL users / community to 17+ Java environments "by force". If you (all) agree, we can go with this direction. |
They are forced to Java 17 anyway, if they want proper Jakarta namespace support in Spring (and don't want to rely on custom Spring 5 shade madness). So I am +1 for moving to Java 17 with 2.0.0 |
Alternative approach (but might be inconsistent):
But I would be in favour for Java 17+ only ;-) |
4cec791
to
125125f
Compare
- sets the compiler level to `17` to comply with Spring 6.x requirements - updates Spring dependencies to version 6.0.13 - adds necessary references to `spring-context` in wikimachine pom.xml - removes reference to `XmlBeanFactory` in `SpringFactory` as this interface was long-time deprecated and removed in Spring 6.x
125125f
to
6b86cac
Compare
spring-context
in wikimachine pom.xmlXmlBeanFactory
inSpringFactory
as this interface was long-time deprecated and removed in Spring 6.x