Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/#78- Remove File: comments, not just Image: comments. #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benldr
Copy link

@benldr benldr commented Apr 1, 2021

This solves issue #78 (I have re-parsed a Wiktionary dump using the updated code and no longer get the issues explained in #78).

I am assuming that [[File mark-up on a Wiktionary page is not used by the jwktl parser anywhere (I am not very familiar with the bulk of jwktl) - obviously if it is used elsewhere then my code change should not be approved!

Apologies if I have not followed the correct convention for contributing to the project- I am new to this. If so, feel free to delete my pull request and make the edit yourself.

@jberkel
Copy link
Contributor

jberkel commented Jan 20, 2022

Hello,

you're right, the parser should remove File: tags as well. However I've just noticed another problem with the image removal, it fails in cases the image has nested links, for example

[[File:foo.png|thumb|Bla bla [[foo]]  bar]]

Currently, this results in bar]].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants