Fix for #50 #54
Fix for #50 #54
Conversation
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
============================================
+ Coverage 75.99% 76.04% +0.04%
Complexity 1321 1321
============================================
Files 101 101
Lines 4629 4633 +4
Branches 801 801
============================================
+ Hits 3518 3523 +5
+ Misses 895 894 -1
Partials 216 216
Continue to review full report at Codecov.
|
|
CLA not signed yet. |
|
I've asked for a confirmation for CCLA, but this may take my employer very long time (huge corp). |
|
Thanks for all your changes. ICLA would be fine for merging. CCLA is recommended, but it depends on what status the work has for your company and how they deal with OSS projects in general. |
| if (label.endsWith("1") || label.endsWith("2") | ||
| || label.endsWith("3") || label.endsWith("4")) | ||
| label = label.substring(0, label.length() - 1).trim(); | ||
| for (String labelSuffix: NOUN_TABLE_LABEL_SUFFIXES) { |
There was a problem hiding this comment.
maybe a RegEx, e.g., \s\d*\*?\*?$ would be more efficient?
There was a problem hiding this comment.
I'd leave it like this for now. Most probably I'll rework this for #57 anyway.
Personally, I'm not a fan of regular expressions. I would not be able to understand what \s\d*\*?\*?$ does without checking the documentation.
|
I'm working to get CCLA but it may take pretty long time. |
|
I've signed and e-mailed the ICLA. |
|
Could this please be merged as well? |
This fixes #50 by adding label.endsWith("*") check.
Unit test is also included using the word Gelb.