Fix simhash slicing and add tests. Fixes #19. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, Tom! Since your contributions are getting non-trivial, I'd like to ask you for filling our contributor's license - this is what we apply for all DKPro open-source software (after discussions with the legal department at the Darmstadt Technical University). Please consult http://dkpro.github.io/contributing/ (you can send it via e-mail: [email protected] ). Thanks :) |
|
I hope it did not scare you off, Tom :)
|
|
You didn't scare me off. :-) I just needed some quiet time to review the agreement. Plus, as I suggested above, I've gone off on a different tack and implemented a new hashing scheme and built a little benchmarking framework so I can compare. I'll have more PRs in the pipe as soon as I stop playing around (and sign the CLA). |
Also includes a more efficient slicing algorithm that could be used, but requires changes elsewhere in the system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds very basic tests for all the static methods in SimHashUtils and fixes the simhash slicing algorithm.
The fixed version uses the current text representation, but I'd actually suggest switching to just using Longs instead of text and computing the slices uses bitmasks. This will not only make the computation of the slices faster and easier to understand, but will speed up the sorting and comparisons during the shuffle phase of clustering (but it does require changes elsewhere in the system).