Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purple potion must now be picked up by player for bridge to work. #2854

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

Loobinex
Copy link
Member

comes with new binaries
Fixes #177
map00091.zip

@Loobinex Loobinex marked this pull request as draft December 21, 2023 20:23
@Loobinex Loobinex marked this pull request as ready for review December 21, 2023 20:23
@Loobinex Loobinex merged commit 8484632 into master Dec 22, 2023
1 check passed
@Loobinex Loobinex deleted the netzcaropickup branch December 22, 2023 00:42
Loobinex added a commit to eddebaby/keeperfx that referenced this pull request Dec 22, 2023
commit 7402f52
Author: demonds1 <[email protected]>
Date:   Fri Dec 22 03:12:28 2023 -0800

    adding null terminator for sanity

commit c5bb194
Merge: 36599c4 5b80682
Author: demonds1 <[email protected]>
Date:   Fri Dec 22 02:56:52 2023 -0800

    Merge branch 'dkfans:master' into func_test__dreaming_of_bridges_tonight

commit 36599c4
Author: demonds1 <[email protected]>
Date:   Fri Dec 22 02:46:29 2023 -0800

    - exposed take_screenshot and added to test
    - set frame_skip to 0 when bridge detected, so map screenshot is correct

commit 5b80682
Author: Loobinex <[email protected]>
Date:   Fri Dec 22 11:43:11 2023 +0100

    Netzcaro: No fancy purple potion, use slab owner instead

commit 3cb5e96
Author: demonds1 <[email protected]>
Date:   Fri Dec 22 01:41:34 2023 -0800

    now digs tiles to open / claim portal

commit ab3e4af
Author: demonds1 <[email protected]>
Date:   Fri Dec 22 00:42:32 2023 -0800

    New functional test to determine if bridges are showing up more or less on different alpha builds.
    - `bug_ai_bridge` (see [ftest_bug_ai_bridge.h](./tests/ftest_bug_ai_bridge.h) [ftest_bug_ai_bridge.c](./tests/ftest_bug_ai_bridge.c)  )

    This test does the following:
    1. reveals the map
    2. nerfs the three good heroes on the center of the map to level 1 and 1hp (uses array of subtile coords to find the things on slabs)
    3. moves the camera to the bridge area
    4. marks the area that will be checked for bridges, so it shows visually on slabs (users can easily see where it will check for bridges)
    5. checks for bridges, exits test early when found, or times out using variable `end_test_after_n_turns` (default 35000 game turns, which seems like a good value to find bridges)
    6. opens the map on game turn 20 (for convenience to see what the AI are doing)
    7. upon test exit, reports the stats to keeperfx.log, increments game seed (if provided seed wasn't 0)

    Example from end of keeperfx.log:
    ```
    FTest: [35000] ftest_bug_ai_bridge__report_stats_and_increment_seed: test_runs: 8
    FTest: [35000] ftest_bug_ai_bridge__report_stats_and_increment_seed: test_runs_with_bridges: 2 (25.00%)
    FTest: [35000] ftest_bug_ai_bridge__report_stats_and_increment_seed: test_runs_without_bridges: 6 (75.00%)
    FTest: [35000] ftest_bug_ai_bridge__report_stats_and_increment_seed: seed 8
    ```

commit 8484632
Author: Loobinex <[email protected]>
Date:   Fri Dec 22 01:39:02 2023 +0100

    Netzcaro: Purple potion must be picked up for bridge (dkfans#2854)

    comes with new binaries
    Fixes dkfans#177

    Also made it possible to use tooltip ID 201 to get no tooltip.

commit 13d9ddf
Author: Pieter Vandecandelaere <[email protected]>
Date:   Thu Dec 21 21:20:02 2023 +0100

    Add map specific cfg to pkg (dkfans#2857)

commit e3911ac
Author: Loobinex <[email protected]>
Date:   Thu Dec 21 03:06:14 2023 +0100

    Disabled objective eyes in Revenge of the Lord (dkfans#2852)

    They always pointed to the player heart, this is not correct. Also fixed one objective not displaying

commit 9442bdd
Author: eddebaby <[email protected]>
Date:   Wed Dec 20 17:08:19 2023 +0000

    Added flag refactor line missed in previous commit (dkfans#2851)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deeper dungeons - Netzcaro - Is this expected?
1 participant