Merge objectsstructs #2853
Merged
Merge objectsstructs #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PieterVdc
added a commit
to PieterVdc/keeperfx
that referenced
this pull request
Dec 21, 2023
Loobinex
reviewed
Dec 22, 2023
config/fxdata/objects.cfg
Outdated
| ;Initial state, only used for chickens | ||
| InitialState = 0 | ||
| ;randomizes the frame at wich each anim starts, so multiple objects don't all make the same movement at same time | ||
| RandomizeStartframe = 0 |
There was a problem hiding this comment.
Start Frame is 2 words, so it should be RandomizeStartFrame
There was a problem hiding this comment.
But better yet, in trapdoor.cfg we have the exact same field, but named RandomStartFrame,... I believe it would make sense to name both the field in the data and the field for the users the same for both traps and objects,...
|
|
|
Implemented feedback |
Loobinex
force-pushed
the
mergeObjectsstructs
branch
from
d6dd8da to
97db1f9
Compare
Loobinex
force-pushed
the
mergeObjectsstructs
branch
from
97db1f9 to
100f443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last non configurable fields now configurable, and cleaned up old struct