Backend #37
Open
Backend #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingmickey
requested changes
May 11, 2023
There was a problem hiding this comment.
First of all, delete all these images from "Filesss" and whenever committing always ignore the test files/folders
| //Testing Route | ||
| router.get('/', (req, res) => { | ||
| console.log('Project Route'); | ||
| res.send('Project Route'); | ||
| }); | ||
|
|
||
| router.post("/add", addProject); | ||
| router.post('/add', upload.single('file'), addProject); |
There was a problem hiding this comment.
Just check whatever changes I told to @Smit-Dama on #33 and update accordingly!
|
|
||
| const gradeSchema = new mongoose.Schema( | ||
| { | ||
| sem1: { |
There was a problem hiding this comment.
add userId as a reference to the User model so that we can map the user with the grades
| }, | ||
| sem8_pdf: { | ||
| type: String | ||
| } |
There was a problem hiding this comment.
Also, why store the grades like this?
I would suggest making a grade array and then inside that array storing the objects of grade which include
- semester
- grade/pointer
- subject (for future if needed to store the details of each subject in the semester)
There was a problem hiding this comment.
Modify this file according to the new Grades model
|
@KreenaShah resolve merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.