Support reading GitHub token from a file #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colindean
approved these changes
Jun 9, 2022
invasi0m
approved these changes
May 24, 2024
rafafrdz
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading the GitHub token from an environment variable is great, but IntelliJ has difficulty loading sbt projects because it doesn't always share the same environment variables with the user's shell, depending on how they are set.
Loading the GitHub token from the git config is also nice unless the user's git config is synchronized as a "dotfile" to a public repository.
Instead, I thought it might be nice to support loading credentials from arbitrary files, a la
Credentials(Path.userHome / ".sbt" / ".credentials")in the sbt docs on credentials.@djspiewak