Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

use level 0 keysyms #276

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

use level 0 keysyms #276

wants to merge 1 commit into from

Conversation

sevz17
Copy link
Collaborator

@sevz17 sevz17 commented Jul 23, 2022

this allow do not have to change the keysym when WLR_MODIFIER_SHIFT is active

NOTE: currently this patch makes ctrl+alt+F# not work, as well as ctrl+alt+backspace

this allow do not have to change the keysym when WLR_MODIFIER_SHIFT is active
@fauxmight
Copy link

The loss of ctrl+alt+F# and ctrl+alt+backspace seems greater than the benefit of usable level-0 keysyms.

Perhaps this is more appropriate as a patch.
Or perhaps merging sevz17/keycodes would be preferable.

@sevz17
Copy link
Collaborator Author

sevz17 commented Jul 24, 2022

The loss of ctrl+alt+F# and ctrl+alt+backspace seems greater than the benefit of usable level-0 keysyms.

This is mostly to match dwm behavior but you're right make it usable would require more work (I'm not sure if it's suitable change to XKB_KEY_F# and XKB_KEY_BackSpace)

Perhaps this is more appropriate as a patch. Or perhaps merging sevz17/keycodes would be preferable.

I have no plans to merge keycodes, (get dwm's folks to use keycodes and I will merge it)

@dimkr
Copy link
Contributor

dimkr commented Jul 24, 2022

https://github.com/djpohly/dwl/compare/main...dimkr:dwl:en-keycodes.patch makes key bindings work when using a non-English layout, and it should be a backward-compatible change.

@sevz17 Would you consider this patch? (Not a replacement for this PR, of course)

@sevz17
Copy link
Collaborator Author

sevz17 commented Jul 24, 2022

Sorry but no. parity with dwm is one of our goals (that's why I won't merge keycodes) and dwm doesn't (and I think it can't) use a specific keymap to handle keybindings

@sevz17 sevz17 marked this pull request as draft July 24, 2022 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants