Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettyplease #22

Merged
merged 2 commits into from
May 2, 2024
Merged

prettyplease #22

merged 2 commits into from
May 2, 2024

Conversation

burrbull
Copy link
Contributor

@burrbull burrbull commented May 1, 2024

I tried to add format option. But it looks like I cannot pass it to write function without global static as it is inside syn fold.
Do you have ideas?

@djmcgill
Copy link
Owner

djmcgill commented May 2, 2024

Putting a bool into the FileIntoMods struct should work, if I'm understanding your question correctly.

@burrbull
Copy link
Contributor Author

burrbull commented May 2, 2024

Really. I just was too tired yesterday to see obvious.

@burrbull
Copy link
Contributor Author

burrbull commented May 2, 2024

Review, please

@djmcgill
Copy link
Owner

djmcgill commented May 2, 2024

Looks good, if you could write a quick test that at least uses the true fmt option, even if it's not worth checking the actual formatting obviously. Absolutely worth having all code paths being called at least.

@djmcgill
Copy link
Owner

djmcgill commented May 2, 2024

LGTM

@djmcgill djmcgill merged commit 41f1fc6 into djmcgill:main May 2, 2024
2 checks passed
@burrbull
Copy link
Contributor Author

burrbull commented May 2, 2024

Could you release, please?

@djmcgill
Copy link
Owner

djmcgill commented May 2, 2024

Done as 0.12.1

@burrbull
Copy link
Contributor Author

burrbull commented May 2, 2024

Done as 0.12.1

Add git tag too, please.

@djmcgill
Copy link
Owner

djmcgill commented May 2, 2024

Done

@burrbull
Copy link
Contributor Author

burrbull commented May 2, 2024

Done

Thanks :). But could you make release from tag to deploy binaries?

@djmcgill
Copy link
Owner

djmcgill commented May 2, 2024

Hmm. I forgot this project had released binaries. Let me remind myself.

@burrbull
Copy link
Contributor Author

burrbull commented May 2, 2024

It is strange. It finishes CI with success and says "uploading artifact is complete" but no archive is present.

@djmcgill
Copy link
Owner

djmcgill commented May 2, 2024

Well, I'll look into it but I wouldn't expect it tonight. But cargo install should still be fine, time for some local caching.

@djmcgill
Copy link
Owner

djmcgill commented May 5, 2024

Right, that's the release tag and assets working finally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants