-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements... #26
Open
Kompwu
wants to merge
15
commits into
djeman:cm-14.1
Choose a base branch
from
Kompwu:cm-14.1
base: cm-14.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improvements... #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be enabled on devices that have OLED displays.
TWRP shouln't interfere with other recovery variants.
- Disable SU - Enable BLOCK_BASED_OTA - Better way to specify KERNEL_CONFIG - Better way to handle prebuilt - Add prebuilt into .gitignore
Set `ro.build.official.release` to true (Help to bypass SafetyNet)
Use extract scripts from: https://github.com/LineageOS/android_vendor_cm/tree/cm-14.1/build/templates
- Reformat code - Update Copyright - Replace if(simslot_count[0] == '2') statement with a switch statement and set persist.dsds.enabled and persist.radio.multisim.config correctly in both case and error handling. - Replace if(strstr(bootloader.c_str(), "J320FN")) statement with a switch statement & Remove fingerprints & Add support for "M" model. - Documenting a little more and correct Djeman's misspellings.
djeman
approved these changes
Sep 2, 2018
@djeman Since you' re approving it, can you merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is much more coming to the kernel side ;)