bb8-redis: document caveat of redis connection config#276
Open
bb8-redis: document caveat of redis connection config#276
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
=======================================
Coverage 76.94% 76.94%
=======================================
Files 6 6
Lines 668 668
=======================================
Hits 514 514
Misses 154 154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djc
reviewed
Dec 15, 2025
Comment on lines
+3
to
+4
| //! _Due to the default connection config, pooled connections have a response timeout and can't be used for blocking commands._ \ | ||
| //! _See [`get_multiplexed_async_connection`](redis::Client::get_multiplexed_async_connection) and [`AsyncConnectionConfig`](redis::AsyncConnectionConfig) for more details._ |
Owner
There was a problem hiding this comment.
Okay, I think I finally understand what the issue is that you're talking about. So did they change this in a recent release?
I guess my beef with this is that it seems in no way to specific to connection pooling, so I don't see why we should document it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation regarding the default configuration of the redis connnection.
#274