Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #93 - Building issue fixed #97

Closed
wants to merge 10 commits into from

Conversation

devendra0009
Copy link
Contributor

Closes #93

Changes

Valid types introduced to variables and added axios for data fetching

Type of change

  • Bug fix

Demo

Screenshot (105)

How has this been tested?

using npm run build on local

@DevilsAutumn
Copy link
Member

@devendra0009 Looks like you have pushed those changes in the old branch i.e, fix-new-branch. The ideal way to add new changes is:

  1. Update the main branch of your forked repository if there are any changes in remote repository.
  2. Pull the changes of the main branch of the repo on your local machine using git pull origin main.
  3. Then create a new branch from that main branch using git checkout -b issue_93.
  4. Do your changes then git add ., git commit -m "commit message" and git push origin issue_93.
  5. There you'll automatically see an option to create a PR.

@DevilsAutumn
Copy link
Member

Hey @devendra0009 , Thankyou for your efforts, we needed this on priority so our team member resolved it in #101 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Frontend crashing while building.
3 participants