Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #198 Created Attendee list API #206

Merged
merged 10 commits into from
Nov 2, 2024
Merged

Fixed #198 Created Attendee list API #206

merged 10 commits into from
Nov 2, 2024

Conversation

Apalakimmortal
Copy link
Contributor

@Apalakimmortal Apalakimmortal commented Oct 20, 2024 •
edited by DevilsAutumn
Loading

Closes #198

Changes

Type of change

  • Bug fix
  • Feature update
  • Breaking change
  • Documentation update

Flags

Demo

How has this been tested?

Author Checklist

  • Code has been commented, particularly in hard-to-understand areas
  • Changes generate no new warnings
  • Vital changes have been captured in unit and/or integration tests
  • New and existing unit tests pass locally with my changes
  • Documentation has been extended, if necessary
  • Merging to main from fork:branchname

Additional context

github-actions[bot]
github-actions bot reviewed Oct 20, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Django India! 🎉🇮🇳

We're so happy to see you contribute. Your efforts mean a lot to us and we're excited to have you on this journey.

Before we proceed, please take a moment to review our contribution guide. It's packed with all the information you need to make your contribution seamless.

If you're fixing an issue from the Django India issue tracker, remember to get it assigned to you before you acutally start working on it.

If you ever need help or just want to chat, the Django India discord server is always open. We're here for you!

And while you're here, don't forget to ⭐ star our repo to show your support! It helps the community grow.

Thank you for being a part of Django India. Together, let's make an amazing community! 🚀

@salty-ivy salty-ivy self-requested a review October 21, 2024 19:45
@salty-ivy
Copy link
Collaborator

@Apalakimmortal is this ready for review?? also can you change the description with context section providing an abstract context about the changes you have made.

@Apalakimmortal
Copy link
Contributor Author

Yes bhaiya it is ready for reviewed. I have made changes in EventRegistration Model in which I have added 2 fields

  1. first_time_attende
    2.attende_type
    First time attende is when a user register for a event 1st time and attende type in which there are 4 options
    Guest,Host,Speaker and Volunteer

Along with Model i have also changed the Serealizer file and admin.py file for registering
Then i created views in which i am sending API which consist of 1. Name of Event 2. Total Number of attende 3. First time attende count and info about all the people who are attending that particular event.

salty-ivy
salty-ivy requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@salty-ivy salty-ivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid, added some comments and changes, make sure to test them out manually before publishing.

CC: @DevilsAutumn

backend/djangoindia/api/views/.cph/.event.py_d9370a604011efc5b3d32a44afd21dc9.prob Outdated Show resolved Hide resolved
backend/djangoindia/db/admin.py Show resolved Hide resolved
backend/djangoindia/api/urls/event.py Outdated Show resolved Hide resolved
backend/djangoindia/api/views/event.py Outdated Show resolved Hide resolved
backend/djangoindia/api/views/event.py Outdated Show resolved Hide resolved
backend/djangoindia/api/serializers/event.py Outdated Show resolved Hide resolved
@Apalakimmortal
Copy link
Contributor Author

Bhaiya do i need to change the things u suggested.

@DevilsAutumn
Copy link
Member

Bhaiya do i need to change the things u suggested.

Yes!

@Apalakimmortal
Copy link
Contributor Author

Will do it by tomorrow

@DevilsAutumn DevilsAutumn mentioned this pull request Oct 25, 2024
Closed
DevilsAutumn
DevilsAutumn requested changes Oct 27, 2024
View reviewed changes
Copy link
Member

@DevilsAutumn DevilsAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left few comments.

backend/djangoindia/api/urls/event.py Outdated Show resolved Hide resolved
backend/djangoindia/api/views/event.py Outdated Show resolved Hide resolved
backend/djangoindia/settings/base.py Outdated Show resolved Hide resolved
backend/djangoindia/api/serializers/event.py Outdated Show resolved Hide resolved
DevilsAutumn
DevilsAutumn requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@DevilsAutumn DevilsAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments. Also you can delete all migrations and create one single migration for all the changes in this PR.

backend/djangoindia/api/views/event.py Show resolved Hide resolved
backend/djangoindia/api/views/event.py Outdated Show resolved Hide resolved
backend/djangoindia/api/serializers/event.py Outdated Show resolved Hide resolved
backend/djangoindia/api/serializers/event.py Outdated Show resolved Hide resolved
@DevilsAutumn
Copy link
Member

DevilsAutumn commented Nov 1, 2024 •
edited
Loading

@Apalakimmortal Thanks 👍 I've rebase this PR to main and pushed few changes + migrations.

salty-ivy
salty-ivy approved these changes Nov 2, 2024
View reviewed changes
Copy link
Collaborator

@salty-ivy salty-ivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @DevilsAutumn @Apalakimmortal

@DevilsAutumn
Copy link
Member

@salty-ivy Thankyou for reviewing 👍

@DevilsAutumn DevilsAutumn merged commit e460c78 into djangoindia:main Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@DevilsAutumn DevilsAutumn DevilsAutumn approved these changes

@salty-ivy salty-ivy salty-ivy approved these changes

@ankanchanda ankanchanda Awaiting requested review from ankanchanda ankanchanda is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create Attendee list API.
3 participants
@Apalakimmortal @salty-ivy @DevilsAutumn