Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #136 -- [BUG] Learn More is not working #197

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

PankajVishw50
Copy link
Contributor

@PankajVishw50 PankajVishw50 commented Oct 9, 2024

Implemented functionality for the 'Learn More' button to open a dialog box when the 'Learn More' button is clicked. The dialog displays relevant content, improving user interaction and addressing the bug where the button previously had no action.

Closes #136

Changes

  • added /container/LearnMoreDialog/LearnMoreDialog.tsx - this is the component which is shown when we click on button
  • used LearnMoreDialog Component in /sections/WhatIsDjango

Type of change

  • Bug fix
  • Feature update
  • Breaking change
  • Documentation update

Flags

No known issues

Demo

chrome_gZutabQkZK

How has this been tested?

  • manual testing

Author Checklist

  • Code has been commented, particularly in hard-to-understand areas
  • Changes generate no new warnings
  • Vital changes have been captured in unit and/or integration tests
  • New and existing unit tests pass locally with my changes
  • Documentation has been extended, if necessary
  • Merging to main from fork:issue_136

Implemented functionality for the 'Learn More' button to open a dialog box
when the 'Learn More' button is clicked. The dialog displays relevant content,
improving user interaction and addressing the bug
where the button previously had no action.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Django India! 🎉🇮🇳

We're so happy to see you contribute. Your efforts mean a lot to us and we're excited to have you on this journey.

Before we proceed, please take a moment to review our contribution guide. It's packed with all the information you need to make your contribution seamless.

If you're fixing an issue from the Django India issue tracker, remember to get it assigned to you before you acutally start working on it.

If you ever need help or just want to chat, the Django India discord server is always open. We're here for you!

And while you're here, don't forget to ⭐ star our repo to show your support! It helps the community grow.

Thank you for being a part of Django India. Together, let's make an amazing community! 🚀

@DevilsAutumn DevilsAutumn merged commit ffed1f4 into djangoindia:main Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Learn More is not working
3 participants