-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add lint check on pre-commit for front end #207
Comments
I would like to work on it. Please assign it to me. |
I am not sure if its a valid issue rn, we don't have proper linting rules configured since #116 is still WIP. IMO, It would be better to get this done after we have proper rules and configurations for frontend. @Saurabhsharma884 @nitin-1926 thoughts? |
Makes sense @DevilsAutumn . We should let that merge first and then see again if this is required and to what extent. That way it will be more streamlined. |
I think once eslint would be integrated, all that would be left is to add it in Its up to rest of us to decide that task would be considered big enough to have its own issue ticket. |
Agreed. But Let not close this issue and wait for #116 to complete. |
i want to work on this issue ,kindly assign me @DevilsAutumn |
After #234 is merged, I think this issue can be picked up. |
Sure , kindly assign it to me @DevilsAutumn |
Summary
Currently We lack lint checks on front end such as prettier
Description
prettier can be added to
pre-commit-config.yaml
and need some additional configurations.References
https://prettier.io/docs/en/
Use Case
No response
Alternatives
No response
Affected Area
Frontend
The text was updated successfully, but these errors were encountered: