Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add lint check on pre-commit for front end #207

Open
salty-ivy opened this issue Oct 20, 2024 · 8 comments
Open

[FEATURE] Add lint check on pre-commit for front end #207

salty-ivy opened this issue Oct 20, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request hacktoberfest

Comments

@salty-ivy
Copy link
Collaborator

Summary

Currently We lack lint checks on front end such as prettier

Description

prettier can be added to pre-commit-config.yaml and need some additional configurations.

References

https://prettier.io/docs/en/

Use Case

No response

Alternatives

No response

Affected Area

Frontend

@salty-ivy salty-ivy added the enhancement New feature or request label Oct 20, 2024
@nitin-1926
Copy link
Contributor

I would like to work on it. Please assign it to me.

@DevilsAutumn
Copy link
Member

I am not sure if its a valid issue rn, we don't have proper linting rules configured since #116 is still WIP. IMO, It would be better to get this done after we have proper rules and configurations for frontend.

@Saurabhsharma884 @nitin-1926 thoughts?

@nitin-1926
Copy link
Contributor

Makes sense @DevilsAutumn . We should let that merge first and then see again if this is required and to what extent. That way it will be more streamlined.

@salty-ivy
Copy link
Collaborator Author

I think once eslint would be integrated, all that would be left is to add it in pre-commit-config.yaml.

Its up to rest of us to decide that task would be considered big enough to have its own issue ticket.

@DevilsAutumn
Copy link
Member

Agreed. But Let not close this issue and wait for #116 to complete.

@nitin-1926 nitin-1926 removed their assignment Oct 30, 2024
@29deepanshutyagi
Copy link
Contributor

i want to work on this issue ,kindly assign me @DevilsAutumn

@DevilsAutumn
Copy link
Member

After #234 is merged, I think this issue can be picked up.
@29deepanshutyagi Do you want to work on this ?

@29deepanshutyagi
Copy link
Contributor

29deepanshutyagi commented Dec 9, 2024

Sure , kindly assign it to me @DevilsAutumn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants