Add github workflows for standard lint checks

[salty-ivy]

Context

checkout .pre-commit-cofig.yaml.

we use the following lint tools on commit.

• flake8
• isort
• black

Approach

add workflows in .github/workflows

[AyushMishraa]

@DevilsAutumn I would like to work on this issue please assign me .

[DevilsAutumn]

@AyushMishraa any updates on this?

[salty-ivy]

@DevilsAutumn what sorts of workflows you need? testing, linting and code cov? are following TDD

[DevilsAutumn]

I think workflows mentioned in #94 is enough for now. not sure if we will be writing tests anytime soon.

[salty-ivy]

# .github/workflows/coverage.yml
name: Post coverage comment

on:
  workflow_run:
    workflows: ["Test"]
    types:
      - completed

jobs:
  test:
    name: Run tests & display coverage
    runs-on: ubuntu-latest
    if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'success'
    permissions:
      # Gives the action the necessary permissions for publishing new
      # comments in pull requests.
      pull-requests: write
      # Gives the action the necessary permissions for editing existing
      # comments (to avoid publishing multiple comments in the same PR)
      contents: write
      # Gives the action the necessary permissions for looking up the
      # workflow that launched this workflow, and download the related
      # artifact that contains the comment to be published
      actions: read
    steps:
      # DO NOT run actions/checkout here, for security reasons
      # For details, refer to https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
      - name: Post comment
        uses: py-cov-action/python-coverage-comment-action@v3
        with:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          GITHUB_PR_RUN_ID: ${{ github.event.workflow_run.id }}

This would mostly used code coverage yml used in django-filter

[DevilsAutumn]

we dont have tests so code coverage wont be useful?

[Suraj1089]

@AyushMishraa any Update on this?

[Suraj1089]

Hi @salty-ivy
Could you please assign this to me if there’s no further update from Ayush?
I believe we should add lint checks for pull requests. It will help to avoid merging poor formatted code.

[DevilsAutumn]

@Suraj1089 we have already added ruff for the pre commit and workflow, so this issue is no longer valid.
But if you are interested we have a similar issue for frontend #207 , if you are interested.