github action to build and push django-docker-box to dockerhub#43
Open
mithron wants to merge 15 commits intodjango:mainfrom
Open
github action to build and push django-docker-box to dockerhub#43mithron wants to merge 15 commits intodjango:mainfrom
mithron wants to merge 15 commits intodjango:mainfrom
Conversation
Remove reference to unmaintained docker hub image
This reverts commit 326cabe.
|
Hi maintainers, would it be possible to merge this, or would you prefer that it be adapted for the GitHub Container Registry or other required changes? I'm happy to make any necessary changes. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This is github action to checkout that repo, checkout django repo and make django-docker-box which can be used to run tests. It DOES NOT run django tests, it's purpose is to provide utility for running django tests in docker. It needs repo owner to define repo secrets for dockerhub: DOCKERHUB_USERNAME and DOCKERHUB_TOKEN to be able to login to dockerhub and push/pull images.
The resulting image example is https://hub.docker.com/repository/docker/mithyronnie/django-docker-box .
P.S. it's done in djangocon sprint so it may be not perfect and ofc comments are appreciated. Thanks in advance.
BR
Ivan.