Open
Conversation
Collaborator
Author
|
@felixxm - I don't suppose we could get the credentials used to push to the Docker registry added here: https://github.com/django/django-docker-box/settings/secrets I'd like to set up a small process to build the test image on a schedule and push, right now they are all rebuilding which takes a long time. |
orf
force-pushed
the
github-actions
branch
2 times, most recently
from
90f0e2e to
62b1199
Compare
auvipy
suggested changes
Oct 16, 2021
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
overall I like the approach followed in this PR.
| fail-fast: false | ||
| matrix: | ||
| python_version: | ||
| - 3.6 |
There was a problem hiding this comment.
we can update the python versions here to 3.8+
| python_version: | ||
| - 3.6 | ||
| - 3.7 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
instead of ubuntu latest wouldn't it better to use ubuntu LTS like ubuntu 20.04 and in future 22.04 etc
| PYTHON_VERSION: 3.6 | ||
| - run: DJANGO_PATH=${GITHUB_WORKSPACE}/django docker-compose run chrome | ||
| env: | ||
| PYTHON_VERSION: 3.6 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.community/t5/GitHub-Actions/Allow-nesting-matrix-includes/m-p/32240#M1058 - this would be super useful here