Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using six from pypi package for django3 compatibility #256

Closed
wants to merge 2 commits into from
Closed

using six from pypi package for django3 compatibility #256

wants to merge 2 commits into from

Conversation

snake-soft
Copy link

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #256 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   63.91%   63.91%           
=======================================
  Files          25       25           
  Lines        1294     1294           
=======================================
  Hits          827      827           
  Misses        467      467           
Impacted Files Coverage Δ
paypal/express/models.py 96.15% <100.00%> (ø)
paypal/payflow/models.py 75.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e58780d...807496d. Read the comment docs.

Copy link
Member

@solarissmoke solarissmoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've dropped support for Python 2 - so I think it's better instead to drop all use of Python 2 compatible shims instead of using six.

@sasha0
Copy link
Member

sasha0 commented Oct 29, 2020

I agree.

@sasha0
Copy link
Member

sasha0 commented Oct 29, 2020

Alright, I already addressed that.

@solarissmoke
Copy link
Member

Closing on the basis that Python 2 support will be dropped entirely in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants