bugfix optiongroupserializer missing #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the problem mentioned at #324 ! |
specialunderwear
requested changes
Apr 12, 2024
oscarapi/serializers/product.py
Outdated
| @@ -186,6 +186,7 @@ class Meta: | |||
|
|
|||
|
|
|||
| class OptionSerializer(OscarHyperlinkedModelSerializer): | |||
| option_group = AttributeOptionGroupSerializer() | |||
There was a problem hiding this comment.
Hi, I think this should be optional, the tests are failing atm!
There was a problem hiding this comment.
Also I think it is important to demonstrate the problem in a test, to make sure there are no regressions in the future
|
@specialunderwear when this is not applied i get errors on admin endpoints when i set: |
specialunderwear
requested changes
Apr 15, 2024
Makefile
Outdated
| @@ -22,7 +22,7 @@ coverage: | |||
| coverage run sandbox/manage.py test oscarapi --settings=sandbox.settings.block_admin_api_true | |||
| coverage run sandbox/manage.py test oscarapi --settings=sandbox.settings.block_admin_api_false | |||
| coverage report -m | |||
| coverage xml -i | |||
| coverage xml -i | |||
There was a problem hiding this comment.
This has to be a tab, you broke the tests by making them spaces
specialunderwear
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
option_group = AttributeOptionGroupSerializer()to:
class OptionSerializer(OscarHyperlinkedModelSerializer):in file: oscarapi/serializers/product.py