Explicit default_auto_field. #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specialunderwear
approved these changes
Jan 15, 2024
|
depends on: #327 |
|
Hi please try and rebase to the main branch because your tests are failing because they miss the fixes in there @JulienPalard |
This is configurable since Django 3.2, which is already the required version for oscar-api. see: https://docs.djangoproject.com/en/3.2/topics/db/models/#automatic-primary-key-fields Explicitly telling which field to use if good, it avoids a supious migration like: $ ./manage.py makemigrations Migrations for 'oscarapi': /home/mdk/src/django-oscar/.venv/lib/python3.11/site-packages/oscarapi/migrations/0002_alter_apikey_id.py - Alter field id on apikey notice the migration is created in the venv, in oscarapi tree, not in the user project, it won't work anyway.
JulienPalard
force-pushed
the
mdk-autofield
branch
from
b955c5e
to
d965240
Compare
|
rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is configurable since Django 3.2, which is already the required version for oscar-api.
see:
https://docs.djangoproject.com/en/3.2/topics/db/models/#automatic-primary-key-fields
Explicitly telling which field to use if good, it avoids a supious migration like:
notice the migration is created in the venv, in oscarapi tree, not in the user project, it won't work anyway.