Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client.py #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update client.py #111

wants to merge 2 commits into from

Conversation

kevinhe2017
Copy link

To fix client authentication issue with RTC 6.0.4 ccm server which has OSLC core version 2.0. The following line should be added to base.py to make it work:
OSLC_CORE_VERSION = "2.0"

@@ -83,6 +83,7 @@ def _get_headers(self):
_allow_redirects = False

_headers = {"Content-Type": self.CONTENT_XML}
_headers["OSLC-Core-Version"] = self.OSLC_CORE_VERSION
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSLC_CORE_VERSION is not defined.

Please move it here from #110.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, don't know how to move it here from #110. This system is so difficult to use.

Fix RTC client authentication failure issue. The OSLC core version should be specified as 2.0.
To fix client authentication issue with RTC 6.0.4 ccm server which has OSLC core version 2.0. The following line should be added to base.py to make it work:
    OSLC_CORE_VERSION = "2.0"
@dixudx
Copy link
Owner

dixudx commented May 24, 2018

@kevinhe2017 Can you help verify whether this works as well for older RTC versions?

@kevinhe2017
Copy link
Author

@dixudx Sorry, I don't have any older RTC version to try it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants