Optionally serve aggregator API alongside DAP API #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends aggregator configuration so that the aggregator API can either: - be served on its own socket address independently of the DAP API - be served on the same address as the DAP API but at some arbitrary path prefix - not be served at all Resolves #1505
tgeoghegan
added
the
byohelper
divergentdave
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
docs/samples/advanced_config/aggregator.yaml and any other files with the old settings should be updated as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends aggregator configuration so that the aggregator API can either:
Resolves #1505