Test that auth token format must match #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If some task accepts an `AuthenticationToken::DapAuth`, it should not be possible to present its value as an `AuthenticationToken::Bearer` and have it be accepted (or vice versa, should a Bearer token happen to also be a legal `DAP-Auth-Token` value). This was already the case because we evaluate tokens using `AuthenticationToken::eq`, but this commit adds a test to explicitly verify this. While we're in here, improve a doccomment to explain that `AuthenticationToken::DapAuth` complies with the interop testing framework as well as the now-obsolete `draft-ietf-ppm-dap-01`, and add a constant for the collection job route to match the ones for aggregation jobs and aggregate shares. Closes #1300
inahga
approved these changes
May 23, 2023
| .map(|token| AuthenticationToken::Bearer(token.as_ref().to_vec())) | ||
| .unwrap(); | ||
|
|
||
| for auth_token in [Some(wrong_token_value), Some(wrong_token_format), None] { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some task accepts an
AuthenticationToken::DapAuth, it should not be possible to present its value as anAuthenticationToken::Bearerand have it be accepted (or vice versa, should a Bearer token happen to also be a legalDAP-Auth-Tokenvalue). This was already the case because we evaluate tokens usingAuthenticationToken::eq, but this commit adds a test to explicitly verify this.While we're in here, improve a doccomment to explain that
AuthenticationToken::DapAuthcomplies with the interop testing framework as well as the now-obsoletedraft-ietf-ppm-dap-01, and add a constant for the collection job route to match the ones for aggregation jobs and aggregate shares.Closes #1300