Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally serve aggregator API on the same TCP port as the DAP API #1505

Closed
tgeoghegan opened this issue Jun 16, 2023 · 0 comments · Fixed by #1547
Closed

Optionally serve aggregator API on the same TCP port as the DAP API #1505

tgeoghegan opened this issue Jun 16, 2023 · 0 comments · Fixed by #1547
Labels
byohelper needed for BYOHelper and self-service task provisioning (#1486)
Milestone
Production readiness

Comments

@tgeoghegan
Copy link
Contributor

The automated task provisioning scheme in #1486 urges Divvi Up subscribers to expose the aggregator API to the internet so that Divvi Up can access it. This would be easier to do if both the DAP API and the aggregator API could be served from the same TCP port. Then the subscriber would only need to configure a single internet ingress.

However, in Divvi Up, we still want to restrict the aggregator API to a distinct port exposed only on a private virtual network, so we want this behavior to be configurable.

In the case where the aggregator API is on the same port as the DAP API, we should also allow configuring path prefixes at which either API is served to mitigate the risk of future API path collisions.
@tgeoghegan tgeoghegan added the byohelper needed for BYOHelper and self-service task provisioning (#1486) label Jun 16, 2023
@tgeoghegan tgeoghegan added this to the Production readiness milestone Jun 16, 2023
@tgeoghegan tgeoghegan mentioned this issue Jun 16, 2023
Closed
tgeoghegan added a commit that referenced this issue Jun 29, 2023
@tgeoghegan
Optionally serve aggregator API alongside DAP API
e36727a 
Extends aggregator configuration so that the aggregator API can either:

 - be served on its own socket address independently of the DAP API
 - be served on the same address as the DAP API but at some arbitrary
   path prefix
 - not be served at all

Resolves #1505
@tgeoghegan tgeoghegan mentioned this issue Jun 29, 2023
Merged
tgeoghegan added a commit that referenced this issue Jun 29, 2023
@tgeoghegan
Optionally serve aggregator API alongside DAP API (#1547)
d6c04f6 
Extends aggregator configuration so that the aggregator API can either:

 - be served on its own socket address independently of the DAP API
 - be served on the same address as the DAP API but at some arbitrary
   path prefix
 - not be served at all

Resolves #1505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
byohelper needed for BYOHelper and self-service task provisioning (#1486)
Projects
None yet
Milestone
Production readiness
Development

Successfully merging a pull request may close this issue.

Optionally serve aggregator API alongside DAP API divviup/janus
1 participant
@tgeoghegan