Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use mocha exit mode to prevent c8 hang #417

Merged
merged 1 commit into from
Sep 15, 2023
Merged

use mocha exit mode to prevent c8 hang #417

merged 1 commit into from
Sep 15, 2023

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Sep 15, 2023

maybe addresses #415

@jbr jbr requested a review from a team as a code owner September 15, 2023 20:16
@github-actions
Copy link

Pull Request Test Coverage Report for Build 6202445382

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.013%
Totals Coverage Status
Change from base Build 6202262973: 0.0%
Covered Lines: 3458
Relevant Lines: 3762
💛 - Coveralls

@jbr
Copy link
Contributor Author

jbr commented Sep 15, 2023 •
edited
Loading

Well it didn't hang that time, and it doesn't seem to make anything worse ¯\(ツ)/¯

@jbr jbr mentioned this pull request Sep 15, 2023
Closed
@jbr jbr merged commit 4e5612d into main Sep 15, 2023
4 checks passed
@jbr jbr deleted the use-mocha-exit-mode branch September 15, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divergentdave divergentdave divergentdave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbr @divergentdave