Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra console.log() statement in test #416

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Remove extra console.log() statement in test #416

merged 2 commits into from
Sep 15, 2023

Conversation

divergentdave
Copy link
Contributor

This removes a log statement that was making my terminal go 🔔

@divergentdave divergentdave requested review from jbr and a team as code owners September 15, 2023 20:11
inahga
inahga approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@inahga inahga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔕

jbr
jbr approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to outlaw console.log for this repository

@github-actions
Copy link

Pull Request Test Coverage Report for Build 6202405037

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.013%
Totals Coverage Status
Change from base Build 6202262973: 0.0%
Covered Lines: 3458
Relevant Lines: 3762
💛 - Coveralls

@jbr jbr merged commit fe58f1a into main Sep 15, 2023
4 checks passed
@jbr jbr deleted the david/remove-console-log branch September 15, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbr jbr jbr approved these changes

@inahga inahga inahga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divergentdave @jbr @inahga