Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish workflow #413

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Fix publish workflow #413

merged 1 commit into from
Sep 15, 2023

Conversation

divergentdave
Copy link
Contributor

This fixes two problems with the publish workflow. First, npm build does not work, as we need to use the npm run command instead to hit our package script. Secondly, we need to build before running tests, because intra-workspace package imports need the dist subdirectories to exist.

@divergentdave divergentdave requested review from jbr and a team as code owners September 15, 2023 19:29
Copy link
Contributor

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed the npm build — That's literally the only thing I miss about yarn

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6202071022

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.94%

Totals Coverage Status
Change from base Build 6201131084: 0.0%
Covered Lines: 3445
Relevant Lines: 3750

💛 - Coveralls

@divergentdave divergentdave merged commit 42e3c6e into main Sep 15, 2023
4 checks passed
@divergentdave divergentdave deleted the david/publish-workflow-fix branch September 15, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants