rename DAPClient to Task #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6177473287
💛 - Coveralls |
inahga
approved these changes
Sep 13, 2023
jbr
commented
Sep 13, 2023
jbr
force-pushed
the
rename-client-to-task
branch
from
e12f4aa
to
b777967
Compare
divergentdave
approved these changes
Sep 15, 2023
| @@ -23,16 +23,16 @@ export interface ReportOptions { | |||
| } | |||
|
|
|||
| /** | |||
| Parameters from which to build a DAPClient | |||
| Parameters from which to build a Task | |||
| @typeParam Measurement The Measurement for the provided vdaf, usually inferred from the vdaf. | |||
| */ | |||
| export interface ClientParameters { | |||
There was a problem hiding this comment.
What do you think of TaskParameters for this? (The long winded way I would refer to this information is "the Client's view of the task parameters")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and rename
Task.taskIdtoTask.idcloses #408