Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stricter checks in tsc #406

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Enable stricter checks in tsc #406

merged 3 commits into from
Sep 11, 2023

Conversation

divergentdave
Copy link
Contributor

This turns on the strict and verbatimModuleSyntax TypeScript compiler options. These options are recommended for libraries by this WIP documentation rewrite. The only fix I had to make was explicitly annotating which imports and exports are for types only (and will be erased in output). I also dropped one-webcrypto as a dependency from one package that wasn't using it.

@divergentdave divergentdave requested review from jbr and a team as code owners September 11, 2023 19:57
Copy link
Contributor

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@divergentdave divergentdave merged commit 5285fcd into main Sep 11, 2023
4 checks passed
@divergentdave divergentdave deleted the david/stricter-ts-2 branch September 11, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants