Stop relying on experimental-specifier-resolution #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if it would be preferable to have "type": "commonjs" now that we no longer require async import (which had been a requirement for wasm, I believe) |
|
There seems to be in-flight updated documentation for ts modules here, in particular "I'm writing a library", but I haven't read it through yet |
|
I think sticking with "type": "module" makes sense. Our main use case is in the browser, and ESM is closer to the desired end result than CJS, even though there will often be a bundling step to produce a single file. Plus, since ESM is more expressive, it could help with tree shaking done by tools in the pipeline. |
jbr
approved these changes
Sep 8, 2023
|
confirmed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #374 by adding
.jsextensions to all intra-package ESM import statements. I also removed the--experimental-specifier-resolution=nodeflag from mocha configuration and one other node command. I tested with the same external plain Node.js project I initially found this issue with, and it can import the packages from tarballs with no further intervention. Based on documentation, this appears to be the preferred way to handle ESM imports in TypeScript. (The project has rejected proposals to havetscrewrite import statements, FWIW) I also confirmed that VS Code's go to definition feature correctly navigates to source.tsfiles when used on these updated import statements.